Add initializer that takes database Connection#1330
Merged
designatednerd merged 1 commit intoapollographql:mainfrom Jul 27, 2020
Merged
Add initializer that takes database Connection#1330designatednerd merged 1 commit intoapollographql:mainfrom
designatednerd merged 1 commit intoapollographql:mainfrom
Conversation
|
@mdarnall: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
Contributor
designatednerd
left a comment
designatednerd
left a comment
There was a problem hiding this comment.
One comment I can fix post-merge if you'd prefer - otherwise looks good!
|
|
||
| func testPassInConnection() { | ||
| let connection = try? Connection() | ||
| XCTAssertNotNil(connection) |
Contributor
There was a problem hiding this comment.
I would recommend making the test a throws test so you don't have to mess around with unwrapping:
func testPassInConnection() throws {
let connection = try Connection()
let cache = try SQLiteNormalizedCache(db: connection)
// Something that tests that the cache exists
}
Author
There was a problem hiding this comment.
Oh, sure I can update that.. thanks
Author
There was a problem hiding this comment.
@designatednerd I updated this to hopefully simplify, but didn't know if there was really a good way to "tests that the cache exists". Instead, I'm simply asserting the creation does not throw.
Because: - It will allow consumers to further configure the Connection in their application and pass it in - See: https://github.com/apollographql/apollo-ios/pull/1162/files#r410367735 This commit: - Adds a new initializer to SQLNormalizedCache
mdarnall
force-pushed
the
inject-connection
branch
from
38acd17 to
d6a4d03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated SQLiteNormalizedCache
Because:
application and pass it in
This commit: