Add extensions property to GraphQLResult.#1370
Merged
designatednerd merged 2 commits intoapollographql:mainfrom Aug 31, 2020
Merged
Add extensions property to GraphQLResult.#1370designatednerd merged 2 commits intoapollographql:mainfrom
designatednerd merged 2 commits intoapollographql:mainfrom
Conversation
- Updated references. - Implemented tests in ParseQueryResponseTests.
|
@paulkite: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
Contributor
designatednerd
left a comment
designatednerd
left a comment
There was a problem hiding this comment.
Hi! Sorry I was on vacation last week. Mostly looks good, just one thought.
| let data = try decode(selectionSet: Data.self, | ||
| from: dataEntry, | ||
| variables: variables) | ||
| let extensions = body["extensions"] as? JSONObject |
Contributor
There was a problem hiding this comment.
This should probably be outside the if let statement since theoretically someone could return stuff in extensions even if data is nil.
Contributor
Author
There was a problem hiding this comment.
Ah. Yeah, I was wondering if I was making the right choice there or not. I'll make an update ASAP. Thank you!
- Moved reference to extensions object into function level scope to be able to assign it to the result even if data doesn't exist in the response. - Updated tests.
designatednerd
approved these changes
Aug 31, 2020
Contributor
designatednerd
left a comment
designatednerd
left a comment
There was a problem hiding this comment.
🎉 Thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue: 1348