Networking Beta Tweaks#1399
Merged
designatednerd merged 6 commits intobetas/networking-stackfrom Sep 18, 2020
Merged
Conversation
…s are also cancelled
…itional error interceptor (with default provision of nil)
… the default store the default Store the default store parameter for Legacy interceptors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
ApolloStoreto take a default cache of theInMemoryNormalizedCache().LegacyInterceptorProviderto take a default store of theApolloStorewith that default cache.InterceptorProviderto provide an error interceptor, along with a default implementation that returnsnil.JSONRequestto beopenso it can be subclassed.