Prevent request headers from getting lost#1420
Merged
designatednerd merged 2 commits intoapollographql:mainfrom Sep 29, 2020
Merged
Prevent request headers from getting lost#1420designatednerd merged 2 commits intoapollographql:mainfrom
designatednerd merged 2 commits intoapollographql:mainfrom
Conversation
|
@dchohfi: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
gabrielrinaldi
approved these changes
Sep 29, 2020
designatednerd
approved these changes
Sep 29, 2020
Contributor
designatednerd
left a comment
designatednerd
left a comment
There was a problem hiding this comment.
Wow, whoops. 🙃
Thanks for adding tests!
Contributor
|
Test failure is a known flaky test, rerunning then I'll get this merged |
Contributor
Author
|
Hey, thank you for merging this, can we get a new tag out? This is breaking my migration. |
Contributor
|
Yeah will try to get this out today - you can also point at the commit on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe that this fixes #1419