Skip to content

Remove unused type#1437

Merged
designatednerd merged 3 commits intomainfrom
rm/unused_type
Oct 5, 2020
Merged

Remove unused type#1437
designatednerd merged 3 commits intomainfrom
rm/unused_type

Conversation

@designatednerd
Copy link
Copy Markdown
Contributor

Addresses #1425 - @knox, a brief look at other things in the networking stack didn't turn up anything we're not still using, but if you see anything else, shout it out. Thanks!

@designatednerd designatednerd added this to the Next Release milestone Oct 5, 2020
@designatednerd designatednerd merged commit 448717a into main Oct 5, 2020
@designatednerd designatednerd deleted the rm/unused_type branch October 5, 2020 22:54
@taher-mosbah
Copy link
Copy Markdown

Hello @designatednerd, in the changelog I see:
BREAKING: Removed the now-unused-in-the-SDK GraphQLHTTPResponseError type. If you were relying on this class, please copy it out of v0.34.1. (#1437)
but doing that I got: 'textEncoding' is inaccessible due to 'internal' protection level and 'statusCodeDescription' is inaccessible due to 'internal' protection level
is it possible to change that please ?

@designatednerd
Copy link
Copy Markdown
Contributor Author

You will want to copy the corresponding extension code - you probably want to delete apollo and just make it a simple extension on HTTPURLResponse rather than the more complex ApolloExtension stuff that's in there.

@vincent-paing
Copy link
Copy Markdown

What should I use instead of GraphQLHTTPResponseError?

@knox
Copy link
Copy Markdown

knox commented Nov 20, 2020

@vincent-paing it's been replaced by ResponseCodeInterceptor.ResponseCodeError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants