Ironing JSONSerialization quirks#1478
Merged
designatednerd merged 2 commits intoapollographql:mainfrom Oct 28, 2020
Merged
Conversation
…ution was to make NSDictionary conform to JSONEncodable. Also fixed an issue where trying to serialize `.some(NSNull())` would result in a crash.
Contributor
designatednerd
left a comment
designatednerd
left a comment
There was a problem hiding this comment.
I agree having true/false is more correct, so I'm fine with that change.
In theory this shouldn't be breaking, since it shouldn't produce different results under the hood with the exception of true/false vs 1/0.
designatednerd
approved these changes
Oct 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed a workaround in the
jsonValueproperty of Optional: the solution was to makeNSDictionaryconform toJSONEncodable.Also fixed an issue where trying to serialize
.some(NSNull())would result in a crash.BREAKING CHANGE (?): This slightly changes the result of the JSON serialization, because instead of taking a
NSDictionary, casting toDictionaryand then callingjsonValueon it, it directly uses theNSDictionaryas theJSONValueitself.Previously, this resulted in having
Boolvalues encoded asNSNumbers, while now they are encoded as atrueorfalseJSON constants. IMHO, this is slightly more correct.