URLSessionClientLiveTests testCleanup#1480
Closed
RolandasRazma wants to merge 1 commit intoapollographql:mainfrom
getfiit:URLSessionClientLiveTests_invalidate_crash
Closed
URLSessionClientLiveTests testCleanup#1480RolandasRazma wants to merge 1 commit intoapollographql:mainfrom getfiit:URLSessionClientLiveTests_invalidate_crash
RolandasRazma wants to merge 1 commit intoapollographql:mainfrom
getfiit:URLSessionClientLiveTests_invalidate_crash
Conversation
Closed
Contributor
|
@RolandasRazma Is this designed to be a failing test? It appears to be failing across the board. |
Contributor
Author
|
yes. It crashes everything - it shouldn't - Test to illustrate problem |
Contributor
|
OK. Wasn't clear from your description if this was to reproduce the problem or act as a solution. Thanks for clarifying! |
Contributor
Author
|
we could fix crash by returning error if you try calling |
Contributor
|
This was helpful for #1489, that should now validate that invalidating the session returns an error. Going to close this PR out in favor of that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test for crash described in #1473