Skip to content

Update legacy CLI to 2.31.0#1510

Merged
designatednerd merged 8 commits intoapollographql:mainfrom
ethansinjin:patch-1
Nov 16, 2020
Merged

Update legacy CLI to 2.31.0#1510
designatednerd merged 8 commits intoapollographql:mainfrom
ethansinjin:patch-1

Conversation

@ethansinjin
Copy link
Copy Markdown
Contributor

@ethansinjin ethansinjin commented Nov 11, 2020

Resolves the CLI output:

Warning: apollo update available from 2.30.2 to 2.31.0.

@designatednerd
Copy link
Copy Markdown
Contributor

@ethansinjin Before I merge this, can you confirm that there are no changes locally to the API.swift for the StarWarsAPI when you build it with this change?

@ethansinjin
Copy link
Copy Markdown
Contributor Author

@designatednerd Good catch! There are indeed two things I missed: updating the SHASUM and regenerating the API.swift files. I just did both, using the following:

shasum -a 256 ./apollo-v2.31.0-darwin-x64.tar.gz

# once in StarWarsAPI and once in UploadAPI
../../scripts/run-bundled-codegen.sh client:codegen --target=swift --includes "./*.graphql" --localSchemaFile="./schema.json" ./API.swift

# in GitHubAPI
../../scripts/run-bundled-codegen.sh client:codegen --target=swift --includes "./Queries/**/*.graphql" --localSchemaFile="./schema.docs.graphql" ./API.swift

@designatednerd
Copy link
Copy Markdown
Contributor

ugh looking forward to getting rid of this stuff one day - unfortunately there's a few things I need to update on my end as well - I'm going to push some stuff to your branch to get it over the finish line

@designatednerd designatednerd added this to the Next Release milestone Nov 16, 2020
@designatednerd designatednerd merged commit b9af090 into apollographql:main Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants