Skip to content

Improve loadRecords performance in SQLiteNormalizedCache #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
designatednerd merged 4 commits into from
Nov 18, 2020
Merged

Improve loadRecords performance in SQLiteNormalizedCache #1519

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b0c4e5
Improve loadRecords performance in SQLiteNormalizedCache especially w…
bharath2020 Nov 15, 2020
e1198dd
rename recordsIndexMap variable in reduce block to resultMap
bharath2020 Nov 16, 2020
293dd3b
Remove unused default parameter while setting value in resultMap
bharath2020 Nov 16, 2020
76d3431
Remove reversal of record indicies when constructing recordsIndexMap …
bharath2020 Nov 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Sources/ApolloSQLite/SQLiteNormalizedCache.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,12 @@ extension SQLiteNormalizedCache: NormalizedCache {
let result: Swift.Result<[Record?], Error>
do {
let records = try self.selectRecords(forKeys: keys)
let recordsIndexMap = records.indices.reversed().reduce(into: [:]) { resultMap, index in
Comment thread
bharath2020 marked this conversation as resolved.
Outdated
resultMap[records[index].key] = index
}

let recordsOrNil: [Record?] = keys.map { key in
if let recordIndex = records.firstIndex(where: { $0.key == key }) {
return records[recordIndex]
}
return nil
recordsIndexMap[key].flatMap { records[$0] }
}

result = .success(recordsOrNil)
Expand Down
⚡