Fix deallocation issue on additionalErrorHandler completion when retry is called.#1563
Merged
designatednerd merged 1 commit intomainfrom Dec 8, 2020
Merged
Fix deallocation issue on additionalErrorHandler completion when retry is called.#1563designatednerd merged 1 commit intomainfrom
additionalErrorHandler completion when retry is called.#1563designatednerd merged 1 commit intomainfrom
Conversation
…ntal callback failures
Contributor
Author
|
Addresses #1544. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the fact that we're wrapping
additionalErrorHandler's callback with aweak selfwas causing a failure when aretrywas done from withinadditionalErrorHandler, becauseself, and in turn the callback queue it was holding onto, got deallocated.This fix pulls out the callback queue to prevent a retain cycle but hang on to the queue so the completion closure can be properly executed.