Add and test validation of multiple vs. single file urls#1580
Merged
designatednerd merged 1 commit intomainfrom Dec 16, 2020
Merged
Add and test validation of multiple vs. single file urls#1580designatednerd merged 1 commit intomainfrom
designatednerd merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses concerns raised by #1557.
One thing that's a bit annoying is that the underlying foundation API can only determine if something is a directory URL or not for a url where something already exists, if the directory hasn't already been created, we can't check it. For a file, we're essentially just checking that the last file extension is
.swift, since there's not really a great way to check it otherwise.