Remove Codable Parsing interceptor and interceptor provider (for now)#1670
Merged
designatednerd merged 1 commit intomainfrom Feb 20, 2021
Merged
Remove Codable Parsing interceptor and interceptor provider (for now)#1670designatednerd merged 1 commit intomainfrom
designatednerd merged 1 commit intomainfrom
Conversation
… as it's not near ready to ship and is causing confusion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a fit of optimism, when I redid all the Network Stack stuff to use interceptors, I added a
Codablebased parsing interceptor for what I thought at the time the Swift Codegen was going to look like. We've since stepped back and are in the midst of rethinking that, mostly because a number of fairly common cases just flat out didn't work with what I'd put together, despite all my testing, because that's just the way The Year Of The Rat went for us all.Since this isn't going to be in use super-soon, all it's doing is confusing people in terms of what they should actually be using. For this reason, I've decided we should remove this and re-add it when there's a more concrete story around what we're doing to parse code for New Codegen™.