Skip to content

Apply cache policy case .default in fetch and watch#1737

Merged
designatednerd merged 1 commit intoapollographql:mainfrom
deepumukundan:patch-1
Apr 1, 2021
Merged

Apply cache policy case .default in fetch and watch#1737
designatednerd merged 1 commit intoapollographql:mainfrom
deepumukundan:patch-1

Conversation

@deepumukundan
Copy link
Copy Markdown
Contributor

The CachePolicy enum has a default policy but it was only used in subscribe. This updates the other 2 locations

The CachePolicy enum has a default policy but it was only used in subscribe. This updates the other 2 locations
@apollo-cla
Copy link
Copy Markdown

@deepumukundan: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link
Copy Markdown
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@deepumukundan
Copy link
Copy Markdown
Contributor Author

@designatednerd Could you merge this? I don't have merge rights

@designatednerd
Copy link
Copy Markdown
Contributor

Thanks for the poke! I had to rerun one test then promptly forgot about it 🤦‍♀️

@designatednerd designatednerd merged commit e2be065 into apollographql:main Apr 1, 2021
@designatednerd designatednerd added this to the Next Release milestone Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants