Test Target Reconfiguration#1745
Merged
AnthonyMDev merged 30 commits intoapollographql:mainfrom Apr 14, 2021
Merged
Conversation
Contributor
AnthonyMDev
commented
Apr 6, 2021
- Consolidates tests into targets for unit test, integration tests, performance test, and code gen tests.
- Moves integration test into new target that only runs on CI for easier local testing.
- Cleans up a few test
- Converts schemes to use XCTestPlans
- Configures CircleCI to use new test plans
Contributor
designatednerd
left a comment
There was a problem hiding this comment.
Looks pretty solid, just a couple of questions!
designatednerd
approved these changes
Apr 12, 2021
Contributor
|
Approved from a content standpoint, obviously we have to figure out what's giving circle a sad. You may need to turn off XCPretty to get the full log barf, but i can't repro this locally either, so you may have to remote in to the running tests 😭 |
…IntegrationTests WIP on UnitTestPlan
…ut of RequestChainTests
20f3e0a to
3f4932e
Compare
…tracting, and checking SHASUM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.