Skip to content

Test Target Reconfiguration#1745

Merged
AnthonyMDev merged 30 commits intoapollographql:mainfrom
AnthonyMDev:Test-Improvements
Apr 14, 2021
Merged

Test Target Reconfiguration#1745
AnthonyMDev merged 30 commits intoapollographql:mainfrom
AnthonyMDev:Test-Improvements

Conversation

@AnthonyMDev
Copy link
Copy Markdown
Contributor

  • Consolidates tests into targets for unit test, integration tests, performance test, and code gen tests.
  • Moves integration test into new target that only runs on CI for easier local testing.
  • Cleans up a few test
  • Converts schemes to use XCTestPlans
  • Configures CircleCI to use new test plans

Copy link
Copy Markdown
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty solid, just a couple of questions!

Comment thread Sources/ApolloTestSupport/MockURLSession.swift
Comment thread Sources/ApolloTestSupport/MockWebSocket.swift
Comment thread Sources/ApolloTestSupport/MockURLSession.swift
@designatednerd
Copy link
Copy Markdown
Contributor

Approved from a content standpoint, obviously we have to figure out what's giving circle a sad. You may need to turn off XCPretty to get the full log barf, but i can't repro this locally either, so you may have to remote in to the running tests 😭

@AnthonyMDev AnthonyMDev merged commit 7afcfc3 into apollographql:main Apr 14, 2021
@AnthonyMDev AnthonyMDev deleted the Test-Improvements branch April 14, 2021 23:06
@calvincestari calvincestari added the codegen Issues related to or arising from code generation label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codegen Issues related to or arising from code generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants