Skip to content

Expose cache policy directive to refetch callers#1832

Closed
calvincestari wants to merge 1 commit intomainfrom
expose-querywatcher-refetch-cache-policy
Closed

Expose cache policy directive to refetch callers#1832
calvincestari wants to merge 1 commit intomainfrom
expose-querywatcher-refetch-cache-policy

Conversation

@calvincestari
Copy link
Copy Markdown
Member

What

This picks up from #1802 to expose the cache policy directive for refetch calls while keeping the internal fetch method private.

Closes #1802

Why

See #1802 (comment).

Tests

None additional - the current WatchQueryTests test cases validate cache/request behaviour so defaulting to anything other than fetchIgnoringCacheData or fetchIgnoringCacheCompletely would fail the tests.

@calvincestari
Copy link
Copy Markdown
Member Author

calvincestari commented Jun 15, 2021

I'm opting to close this PR and instead modify the original #1802 PR.

  • partly me figuring out how to work with contributor forks
  • I think it's a good open-source practice to keep the conversation/work in the original PR since it's better feedback to the contributor

@calvincestari calvincestari deleted the expose-querywatcher-refetch-cache-policy branch June 15, 2021 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants