Skip to content

Add docs and improve merging of records from WebSockets into cache.#1892

Merged
AnthonyMDev merged 2 commits intomainfrom
websocket-store-doc-update
Aug 5, 2021
Merged

Add docs and improve merging of records from WebSockets into cache.#1892
AnthonyMDev merged 2 commits intomainfrom
websocket-store-doc-update

Conversation

@AnthonyMDev
Copy link
Copy Markdown
Contributor

@AnthonyMDev AnthonyMDev commented Aug 4, 2021

The previous PR (#1889) has a few issues here. This fixes them.

  • We shouldn't parse the result twice here. If the results are parsed with records, we don't need to also call parseResultsFast().
  • We should be passing the context identifier to the publish() function.
  • Completion should wait for the cache merge to occur before being called.

Copy link
Copy Markdown
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on these changes - nice work.

@AnthonyMDev AnthonyMDev merged commit a186027 into main Aug 5, 2021
@AnthonyMDev AnthonyMDev deleted the websocket-store-doc-update branch August 5, 2021 16:54
@AnthonyMDev AnthonyMDev added the include-in-changelog Indicates that changes from a PR should be noted in the changelog for their release. label Aug 5, 2021
ketenshi added a commit to scorebet/apollo-ios that referenced this pull request Aug 16, 2021
* main: (856 commits)
  Add execution tests for ApolloClient clearCache callback queue (apollographql#1901)
  Use the provided callback queue instead of the store's default. (apollographql#1904)
  chore(deps): update dependency path-parse to 1.0.7 [security] (apollographql#1899)
  Release - 0.46.0 (apollographql#1897)
  Update subscriptions tutorial to be compatible with recent changes (apollographql#1893)
  Add docs and improve merging of records from WebSockets into cache. (apollographql#1892)
  Publish response from the `WebSocketTransport` to the `ApolloStore` (apollographql#1889)
  fix(deps): update dependency gatsby-theme-apollo-docs to v4.7.14
  Removing Swift codegen (v1) (apollographql#1873)
  Update toolchain versions used by circleci (apollographql#1875)
  fix(deps): update dependency gatsby-theme-apollo-docs to v4.7.13
  Community Updates - ROADMAP/README (apollographql#1867)
  [Release] - 0.45.0 (apollographql#1862)
  WebSocket Fixes - Revert to Starscream 3.x and invert dependency (apollographql#1861)
  Docs/discussions_2_community branch changes (apollographql#1858)
  Replace spectrum with Discourse (apollographql#1857)
  fix(deps): update dependency gatsby-theme-apollo-docs to v4.7.12
  Configure Renovate (apollographql#1854)
  Revert "Reconfiguring renovate 2/2"
  Reconfiguring renovate 2/2
  ...

# Conflicts:
#	Sources/Apollo/GraphQLQueryWatcher.swift
#	Sources/ApolloWebSocket/WebSocketTransport.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

include-in-changelog Indicates that changes from a PR should be noted in the changelog for their release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants