Merged
Conversation
67c072e to
c31c281
Compare
designatednerd
approved these changes
Sep 21, 2021
Contributor
designatednerd
left a comment
There was a problem hiding this comment.
LGTM save the couple comments - no need for re-review once they're addressed
| ### `errorDescription` | ||
|
|
||
| ```swift | ||
| public var errorDescription: String? |
Contributor
There was a problem hiding this comment.
Guh, I wish we could convince the docs to just use the errorDescription as the documentation....
Member
Author
|
Announced on Twitter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff
0.48.0...main.
Relevant changes:
Things to do in this PR
Configuration/Shared/Project-Version.xcconfig.CHANGELOG.mdwith all relevant changes since the prior version. Please include PR numbers and mention contributors for external PR submissions.api-reference.mdto re-generate documentation from source for all included libraries.Other things to do before a release - these need to become automated CI builds
mainbuilds with a test Swift Package Manager project.mainbuilds with a test CocoaPods project.mainbuilds with a test Carthage project (make sure to use--use-xcframeworks).Things to do as part of releasing
major.minor.patchto GitHub for SPM/Carthage.CHANGELOG.mdcontents.pod trunk push Apollo.podspecto publish to CocoaPods. You will need write permissions for this, please contact one of the maintainers if you need access to do this.Things to do after release