Remove unnecessary assertion failure #2005
Merged
designatednerd merged 1 commit intomainfrom Oct 26, 2021
Merged
Conversation
… debugging if a nil action block was passed in on purpose.
|
Awesome, looking forward to getting this merged and released! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2004.
After consulting with @martijnwalraven it seems like leaving this in as a
debugPrintwill help with the original purpose of this line, which is to provide some information about an unhandled failure, without causing assertions in debug mode whennilhas been purposely passed in.