Skip to content

Xcode 14 has deprecated bitcode and so we should disable it#2396

Closed
stareque-atlassian wants to merge 1 commit intoapollographql:mainfrom
atlassian-forks:fix/xcode-14-error-bitcode
Closed

Xcode 14 has deprecated bitcode and so we should disable it#2396
stareque-atlassian wants to merge 1 commit intoapollographql:mainfrom
atlassian-forks:fix/xcode-14-error-bitcode

Conversation

@stareque-atlassian
Copy link
Copy Markdown
Contributor

This document explains how bitcode is not supported in Xcode 14:

Starting with Xcode 14, bitcode is no longer required for watchOS and tvOS applications, and the App Store no longer accepts bitcode submissions from Xcode 14.
Xcode no longer builds bitcode by default and generates a warning message if a project explicitly enables bitcode: “Building with > bitcode is deprecated. Please update your project and/or target settings to disable bitcode.” The capability to build with bitcode will be removed in a future Xcode release. IPAs that contain bitcode will have the bitcode stripped before being submitted to the App Store. Debug symbols for past bitcode submissions remain available for download. (86118779)

https://developer.apple.com/documentation/Xcode-Release-Notes/xcode-14-release-notes

…oved build phase "Ensure no build settings are in the Xcode project"
@apollo-cla
Copy link
Copy Markdown

@stareque-atlassian: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 27, 2022

👷 Deploy request for apollo-ios-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9cd4fa9

@calvincestari
Copy link
Copy Markdown
Member

Thanks for the contribution @stareque-atlassian! This project uses xcconfig files so we can't remove that build phase from the project though; it's there to ensure we don't have a mixed configuration. I'm pretty sure there is a way we can do this with xcconfig files.

@calvincestari
Copy link
Copy Markdown
Member

@stareque-atlassian I've created #2397 to keep track of this issue. I'm going to close this PR as we can't merge a solution that removes the project settings check build phase. If you find another way to achieve this please feel free to reopen this PR or create a new one - thanks.

@calvincestari calvincestari linked an issue Jul 27, 2022 that may be closed by this pull request
@stareque-atlassian
Copy link
Copy Markdown
Contributor Author

Thanks so much for the quick response. Raised a PR for this with changes only in xcconfig files #2398

Tested it manually by using carthage to build it successfully with Xcode 14.

Can I request to make a hotfix tag 0.51.3. This PR branch is rebased from the tag 0.51.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Xcode 14 drops support for Bitcode

3 participants