Fix: Added missing fulfilledFragments to generated initializers#3067
Merged
AnthonyMDev merged 4 commits intomainfrom Jun 12, 2023
Merged
Fix: Added missing fulfilledFragments to generated initializers#3067AnthonyMDev merged 4 commits intomainfrom
AnthonyMDev merged 4 commits intomainfrom
Conversation
… of just merged fragment selections
✅ Deploy Preview for apollo-ios-docs canceled.
|
BobaFetters
reviewed
Jun 9, 2023
| var next = selectionSet.scopePath.last.value.scopePath.head | ||
| while next.next != nil { | ||
| defer { next = next.next.unsafelyUnwrapped } | ||
| var currentNode = Optional(selectionSet.scopePath.last.value.scopePath.head) |
Member
There was a problem hiding this comment.
Like the renaming here from just using next
BobaFetters
approved these changes
Jun 9, 2023
Member
BobaFetters
left a comment
BobaFetters
left a comment
There was a problem hiding this comment.
This looks good to me, nice work!
This was referenced Jun 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2989
The generated initializers were missing the fulfilled fragments in certain cases. When you were merging in selection sets from a named fragment, we only were including the root of that fragment. This was missing the nested type cases of that fragment, and was just completely wrong if you were actually merging from a nested entity field on that named fragment.
This now uses the merged sources to calculate all of the selection sets that would be fulfilled from the fragment root to the merged source.