Fixes #435 Invoking Query.Data(jsonObject:) fails for queries with params …#437
Merged
martijnwalraven merged 2 commits intoapollographql:masterfrom Jan 16, 2019
diegorozen:parameter_passing
Merged
Fixes #435 Invoking Query.Data(jsonObject:) fails for queries with params …#437martijnwalraven merged 2 commits intoapollographql:masterfrom diegorozen:parameter_passing
martijnwalraven merged 2 commits intoapollographql:masterfrom
diegorozen:parameter_passing
Conversation
|
@diegorozen: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Contributor
|
Thanks! Would you mind adding a test for this? Just want to make sure we don't introduce any regressions in the future. |
Contributor
Author
|
@martijnwalraven Added a new test group. It includes testing a conditional query with and without params as well as a simpler query built from JsonObject. We could repeat all the tests from ParseQueryResponseTests to run through Query.Data(jsonObject:), but it seemed like an overkill |
Contributor
|
Thanks, this looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#435
Adds an optional 'variables' parameter to pass to the executor