Use EnumeratedSequence.Iterator#446
Closed
palpatim wants to merge 1 commit intoapollographql:masterfrom
palpatim:patch-1
Closed
Use EnumeratedSequence.Iterator#446palpatim wants to merge 1 commit intoapollographql:masterfrom palpatim:patch-1
palpatim wants to merge 1 commit intoapollographql:masterfrom
palpatim:patch-1
Conversation
Use `EnumeratedSequence.Iterator` instead of `EnumeratedIterator<IndexingIterator>`, which causes build failures in Xcode 10.2 beta 1. Fixes #444 NOTE: Tests pass in both Xcode 10.1 and Xcode 10.2 beta 1.
|
@palpatim: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Contributor
|
I just merged #427, which includes a similar fix. |
|
- |
|
Hi. Should I use EnumeratedSequence.Iterator as type for keyIterator? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
EnumeratedSequence.Iteratorinstead ofEnumeratedIterator<IndexingIterator>, which causes build failures in Xcode 10.2 beta 1.Fixes #444
NOTE: Tests pass in both Xcode 10.1 and Xcode 10.2 beta 1.