Skip to content

Swift 5 and Xcode 10.2 support#482

Closed
fassko wants to merge 5 commits intoapollographql:masterfrom
fassko:swift_5
Closed

Swift 5 and Xcode 10.2 support#482
fassko wants to merge 5 commits intoapollographql:masterfrom
fassko:swift_5

Conversation

@fassko
Copy link
Copy Markdown
Contributor

@fassko fassko commented Mar 26, 2019

No description provided.

@martijnwalraven
Copy link
Copy Markdown
Contributor

Thanks for the PR! But I'm hoping now that Xcode 10.2 is out we can land the more comprehensive #475.

@fassko
Copy link
Copy Markdown
Contributor Author

fassko commented Mar 26, 2019

@martijnwalraven Thanks. That PR #475 would be great. In this PR I updated Starscream. I released Swift 5 and Xcode 10.2 support for that library. Although there is still hanging #466

@martijnwalraven
Copy link
Copy Markdown
Contributor

What do you think we should do while we wait for #475? Any chance you can update #466 with the new Starscream version? Or would you prefer to close that one and merge this PR instead?

@fassko
Copy link
Copy Markdown
Contributor Author

fassko commented Mar 26, 2019

I will update #466 so it could be easier to merge after #475 I hope it will be soon merged. :)

@martijnwalraven
Copy link
Copy Markdown
Contributor

Closing this in favor of #475 and #466.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants