Add various performance improvements#551
Merged
designatednerd merged 4 commits intomasterfrom Jul 2, 2019
Merged
Conversation
martijnwalraven
force-pushed
the
performance-improvements
branch
from
86523ff to
c84fe16
Compare
Contributor
|
@martijnwalraven Wanna update this in the 🇳🇱 morning and make it non-draft? |
Merged
Contributor
|
ergh, @martijnwalraven I think you need to push some new code after you mark a draft ready - unfortunately travis keeps saying this is a draft PR. |
Contributor
|
@martijnwalraven I'm seeing |
Contributor
|
OK, looks like it's the Thread Sanitizer throwing a fit that's causing these inconsistent fails. This is happening considerably more often than it is on Here's the error I'm getting in
Here's the big old barf of notes from Xcode. |
designatednerd
suggested changes
Jul 1, 2019
Contributor
designatednerd
left a comment
designatednerd
left a comment
There was a problem hiding this comment.
We need to figure out what's making thread sanitizer lose its tiny mind
Closed
designatednerd
approved these changes
Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds various performance improvements, mostly focusing on response parsing. Among other things, it changes the response path representation to a linked list, and it adds a fast path for parsing results that don't need to be stored in the cache, which can be activated with a new
.fetchIgnoringCacheCompletelycache policy. For large query results, this seems to show an 80-85% performance improvement.