[airbnb] Fix missing "Foundation" imports#620
Merged
designatednerd merged 1 commit intoapollographql:masterfrom Jul 11, 2019
Merged
[airbnb] Fix missing "Foundation" imports#620designatednerd merged 1 commit intoapollographql:masterfrom
designatednerd merged 1 commit intoapollographql:masterfrom
Conversation
designatednerd
approved these changes
Jul 11, 2019
Contributor
designatednerd
left a comment
designatednerd
left a comment
There was a problem hiding this comment.
It looks like this is the same issue hitting this commenter using SPM to integrate.
A couple of these are my fault for not realizing LocalizedError is part of Foundation and not raw Swift, but a couple of these are in files that haven't been touched in approximately forever. Interesting that they're just freaking out now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed when pulling in 0.11.0 to Airbnb that there were a bunch of failures related to certain types not being defined. This was happening due to missing
Foundationimports.This PR simply adds those imports where appropriate.