Fix type error + Use Sorted Keys Where Possible#628
Merged
designatednerd merged 3 commits intomasterfrom Jul 12, 2019
Merged
Conversation
Contributor
Author
|
@dmandarino wanna give me a ✅if you feel this is good or feedback if you have it? |
|
@designatednerd Looks good to me. I've tested here too using the project I'm working on and everything looks fine and passed :D |
dmandarino
approved these changes
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #624 and some of the failures we saw when @dmandarino tried to add a test, this fixes #623.
In this PR:
[String: AnyHashable]to[String: Any]to allow for proper encoding of types like booleans.sortedKeyswhen generating JSON on platforms where that's possible/me shakes fist at sky for
.sortedKeysonly being on iOS 11 and above