Skip to content

Fix type error + Use Sorted Keys Where Possible#628

Merged
designatednerd merged 3 commits intomasterfrom
fix/sorted-keys
Jul 12, 2019
Merged

Fix type error + Use Sorted Keys Where Possible#628
designatednerd merged 3 commits intomasterfrom
fix/sorted-keys

Conversation

@designatednerd
Copy link
Copy Markdown
Contributor

Based on #624 and some of the failures we saw when @dmandarino tried to add a test, this fixes #623.

In this PR:

/me shakes fist at sky for .sortedKeys only being on iOS 11 and above

@designatednerd
Copy link
Copy Markdown
Contributor Author

@dmandarino wanna give me a ✅if you feel this is good or feedback if you have it?

@dmandarino
Copy link
Copy Markdown

@designatednerd Looks good to me. I've tested here too using the project I'm working on and everything looks fine and passed :D

@designatednerd designatednerd merged commit b1a6761 into master Jul 12, 2019
@designatednerd designatednerd deleted the fix/sorted-keys branch July 12, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GET is not working in 0.11.0

2 participants