Expose GraphQLQueryWatcher init method#750
Merged
designatednerd merged 1 commit intoapollographql:masterfrom Sep 4, 2019
Merged
Conversation
|
@mikaelbartlett: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
designatednerd
approved these changes
Sep 4, 2019
Contributor
designatednerd
left a comment
designatednerd
left a comment
There was a problem hiding this comment.
Ah yeah good catch - ApolloQueryWatcher is returned from the watch protocol method, but since this wasn't public there wasn't a way to instantiate one.
Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small fix exposing GraphQLQueryWatcher init method.
We would like to have this to be able to mock and test using ApolloClientProtocol.