-
Notifications
You must be signed in to change notification settings - Fork 749
Added correct way of default parameters #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
designatednerd
merged 9 commits into
apollographql:master
from
kimdv:kimdv/change-default-parameter-in-request-creator
Oct 3, 2019
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e8085f0
Added correct way of default parameters
kimdv 6e4cc7f
Remove default parameter
kimdv 4ef637c
Remove default parameters
kimdv 04fd12f
Renamed to RequestCreatorTests to match what it is doing. Added reque…
kimdv 8db2e1c
Move TestRequestCreator -> TestCustomRequestCreator
kimdv 686fb75
Removed fileprivate and made import testable
kimdv 28bfb0b
Made method public as it was missing
kimdv 3036c97
Fixed tests
kimdv 8574ab9
Made tests pass. Becaue TestCustomrequestCreator uses a dictionary we…
kimdv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.