Added correct way of default parameters #804
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| // | ||
| // TestCustomRequestCreator.swift | ||
| // Apollo | ||
| // | ||
| // Created by Kim de Vos on 02/10/2019. | ||
| // Copyright © 2019 Apollo GraphQL. All rights reserved. | ||
| // | ||
|
|
||
| import Apollo | ||
|
|
||
| fileprivate struct TestCustomRequestCreator: RequestCreator { | ||
| public func requestBody<Operation: GraphQLOperation>(for operation: Operation, sendOperationIdentifiers: Bool) -> GraphQLMap { | ||
| var body: GraphQLMap = [ | ||
| "test_variables": operation.variables, | ||
| "test_operationName": operation.operationName, | ||
| ] | ||
|
|
||
| if sendOperationIdentifiers { | ||
| guard let operationIdentifier = operation.operationIdentifier else { | ||
| preconditionFailure("To send operation identifiers, Apollo types must be generated with operationIdentifiers") | ||
| } | ||
|
|
||
| body["test_id"] = operationIdentifier | ||
| } else { | ||
| body["test_query"] = operation.queryDocument | ||
| } | ||
|
|
||
| return body | ||
| } | ||
|
|
||
| public func requestMultipartFormData<Operation: GraphQLOperation>(for operation: Operation, | ||
| files: [GraphQLFile], | ||
| sendOperationIdentifiers: Bool, | ||
| serializationFormat: JSONSerializationFormat.Type, | ||
| manualBoundary: String?) throws -> MultipartFormData { | ||
| let formData: MultipartFormData | ||
|
|
||
| if let boundary = manualBoundary { | ||
| formData = MultipartFormData(boundary: boundary) | ||
| } else { | ||
| formData = MultipartFormData() | ||
| } | ||
|
|
||
| let fields = requestBody(for: operation, sendOperationIdentifiers: false) | ||
| for (name, data) in fields { | ||
| if let data = data as? GraphQLMap { | ||
| let data = try serializationFormat.serialize(value: data) | ||
| formData.appendPart(data: data, name: name) | ||
| } else if let data = data as? String { | ||
| try formData.appendPart(string: data, name: name) | ||
| } else { | ||
| try formData.appendPart(string: data.debugDescription, name: name) | ||
| } | ||
| } | ||
|
|
||
| files.forEach { | ||
| formData.appendPart(inputStream: $0.inputStream, contentLength: $0.contentLength, name: $0.fieldName, contentType: $0.mimeType, filename: $0.originalName) | ||
| } | ||
|
|
||
| return formData | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth adding one test to this file where
sendOperationIdentifersistruejust to make sure that's actually including the operation identifierThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the default implementation here was actually false.
Maybe that is for another PR?
I can open an issue to you can track it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just not to add something that is not related to this PR and RequestCreator? 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'll add it in a follow-up PR - you don't need to open an issue for it, I'll leave this comment open