Add documentation for Subscriptions + ApolloWebSocket#853
Merged
designatednerd merged 5 commits intomasterfrom Oct 22, 2019
Merged
Add documentation for Subscriptions + ApolloWebSocket#853designatednerd merged 5 commits intomasterfrom
designatednerd merged 5 commits intomasterfrom
Conversation
This was referenced Oct 22, 2019
Closed
Contributor
Author
|
Would still love any feedback in the form of comments here or issues on the repo, but I'm gonna go ahead and merge this. |
Contributor
|
You turned on the thread sanitizer for the Run action and not Test. I haven't had the time to look at ApolloStore, but I'm working on a PR for data races in WebSocketTransport. |
Contributor
Author
|
Oh son of a... 🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️🤦♀️ Good catch @aivcec. I'll re-open that issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
Turned the thread sanitizer on for all tests (sort of addresses Look into TSAN failures #600)(whoops, turns out I only turned it on for the run action)Would love feedback from anyone who's used or tried to use
ApolloWebSocketon these docs!