GraphManager/Engine Headers + minor WebSocket cleanup#858
Merged
designatednerd merged 14 commits intomasterfrom Oct 29, 2019
Merged
GraphManager/Engine Headers + minor WebSocket cleanup#858designatednerd merged 14 commits intomasterfrom
designatednerd merged 14 commits intomasterfrom
Conversation
This was referenced Oct 24, 2019
js
reviewed
Oct 24, 2019
| if version.isEmpty { | ||
| version.append(buildNumber) | ||
| } else { | ||
| version.append("-\(buildNumber)") |
Contributor
There was a problem hiding this comment.
I actually decided against this on my end as I'm increasing the build number on each build (based of number of commits) and it makes the "Clients" view in Apollo Engine a bit noisy for the non-public environments/variants. YMMV of course and it's always configurable anyway.
Contributor
Author
There was a problem hiding this comment.
Yeah in my past experience when I've had build number auto-incrementing it's actually been quite helpful in being able to identify exactly where I broke something 😄. And as you said, it's configurable, so if people don't like the default, they can always adjust.
designatednerd
force-pushed
the
add/headery-fun
branch
from
20b316f to
c925993
Compare
designatednerd
force-pushed
the
add/headery-fun
branch
from
c925993 to
adb8586
Compare
… sure headers are actually sent
designatednerd
force-pushed
the
add/headery-fun
branch
from
adb8586 to
6aa8c62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR: