ApolloWebSocket should depend on Apollo since it imports Apollo.#906
Merged
designatednerd merged 1 commit intoapollographql:masterfrom Nov 16, 2019
JimRoepcke:make-apollowebsocket-depend-on-apollo
Merged
ApolloWebSocket should depend on Apollo since it imports Apollo.#906designatednerd merged 1 commit intoapollographql:masterfrom JimRoepcke:make-apollowebsocket-depend-on-apollo
designatednerd merged 1 commit intoapollographql:masterfrom
JimRoepcke:make-apollowebsocket-depend-on-apollo
Conversation
Trying to build my project to profile failed because SplitNetworkTransport.swift does import Apollo but ApolloWebSocket doesn't depend on Apollo in Package.swift like it needs to.
designatednerd
approved these changes
Nov 16, 2019
Contributor
|
Good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to profile my iOS app project failed because SplitNetworkTransport.swift does
import Apollobut ApolloWebSocket doesn't depend on Apollo in Package.swift like it needs to.With this change I am able to profile my app. I'm using Xcode 11.1.