[apollo-datasource-rest] Error thrown when parsing 204 response

[EspadaV8]

We have a number of endpoints that return the 204 HTTP status code when handling DELETE requests. These are currently throwing an error because of the attempt to parse the body (

apollo-server/packages/apollo-datasource-rest/src/RESTDataSource.ts

Line 94 in c908fac

return (this.parseBody(response) as any) as Promise<TResult>;

), however, for these responses there isn't a body. To handle this I think that didReceiveResponse should check the status code before attempting to parse the body.

[EspadaV8]

(more than happy to open a small PR to handle this if you're okay with it the suggestion, wanted to get feedback beforehand)

[abernix]

Fixed via #2446! Thanks for reporting this originally.