Allow user-defined GraphQLExtensions, add apollo-engine-reporting#1105
Merged
Conversation
glasser
force-pushed
the
glasser/extensions-0.1.0
branch
4 times, most recently
from
6c3e890 to
ae9c187
Compare
glasser
changed the title
glasser
force-pushed
the
glasser/extensions-0.1.0
branch
from
ae9c187 to
a64909b
Compare
- Actually call validationDidStart and parsingDidStart.
- Use new graphql-extensions API which:
- replaces fooDidEnd with a handler returned by fooDidStart
- adds options to various methods
- has a new willSendResponse method
- requires you to construct the extension objects yourself (but make
the external API for specifying extensions to ApolloServer be
factories, because extensions are per request)
- Make a better effort at consistently calling end handlers even on error
glasser
force-pushed
the
glasser/extensions-0.1.0
branch
2 times, most recently
from
1623727 to
be28483
Compare
glasser
changed the title
glasser
force-pushed
the
glasser/extensions-0.1.0
branch
from
2b3a5e6 to
4405405
Compare
This was referenced Jun 4, 2018
Merged
ghost
mentioned this pull request
This was referenced Jan 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started with #934 by @sebas5384 (which allows you to pass in your own extensions) and updated it for a new graphql-extensions API.
Actually call validationDidStart and parsingDidStart.
Use new graphql-extensions API which:
Make a better effort at consistently calling end handlers even on error