Apollo server 2.0 - DatasourceREST - Improve types#1190
Merged
martijnwalraven merged 2 commits intoJun 19, 2018
Merged
Conversation
Contributor
|
Thanks, this looks great! The new |
Contributor
|
I ended up defining I also added |
Contributor
Author
|
@martijnwalraven Nice! Thank you for your support and your reactivity 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I'm just begining to play a little bit with Apollo server 2.0, datasourceRest and typescript.
This PR include some little improvements:
anyto permit to type the response easilyURLSearchParamsto be more precise about the possibilities of the APIPATCHmethod