Typescript Improvements and esModuleInterop fix#1210
Merged
Conversation
Merged
hwillson
added a commit
that referenced
this pull request
Sep 20, 2018
`esModuleInterop` was enabled in e4164c8 to help with importing from packages that use default exports. Those changes were reverted in #1210 to work around a few reported issues. Those issues are no longer relevant, so this commit re-enables `esModuleInterop`, and updates all default imports to use the more common (standard) import syntax.
abernix
pushed a commit
that referenced
this pull request
Sep 21, 2018
`esModuleInterop` was enabled in e4164c8 to help with importing from packages that use default exports. Those changes were reverted in #1210 to work around a few reported issues. Those issues are no longer relevant, so this commit re-enables `esModuleInterop`, and updates all default imports to use the more common (standard) import syntax.
ShiyamRajan
pushed a commit
to ShiyamRajan/apollo-server-lambda
that referenced
this pull request
Nov 2, 2018
`esModuleInterop` was enabled in apollographql/apollo-server@e4164c8 to help with importing from packages that use default exports. Those changes were reverted in apollographql/apollo-server#1210 to work around a few reported issues. Those issues are no longer relevant, so this commit re-enables `esModuleInterop`, and updates all default imports to use the more common (standard) import syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes exModuleInterop, which was breaking some builds with TS #1182
Additionally adds in support for strings passed directly to gql and adds the documentation requested by #1194. For example: