Fix dependencies and exports#1257
Merged
Merged
Conversation
Contributor
|
@olistic Thank you so much! |
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1251 by adding the
graphql-toolsandgraphql-subscriptionsdependencies to integrations to allowexport * from 'graphql-tools'andexport * from 'graphql-subscriptions'from them.Also, we are not exporting everything from
graphql-toolsandgraphql-subscriptionsfrom theapollo-server-corepackage anymore (no consumer of it was using any of those exports). If there's any objection with this, I can revert that commit.