[2.0] Switch apollo-engine-reporting to use fetch instead of the Node request module#1274
Merged
Conversation
Contributor
|
@martijnwalraven Thank you so much! Super excited to get edge fully supported |
Merged
ghost
mentioned this pull request
glasser
added a commit
that referenced
this pull request
Aug 27, 2019
We do craft these messages to be useful, so we want them in your logs! This regressed in #1274.
glasser
reviewed
Aug 27, 2019
| console.log(`Engine report: status ${response.statusCode}`); | ||
|
|
||
| if (response.status >= 500 && response.status < 600) { | ||
| throw new Error(`${response.status}: ${response.statusText}`); |
Member
There was a problem hiding this comment.
I assume this change from body to statusText (which leaves out the response body which we do craft in the server to be read by humans in logs) was unintentional. See #3218.
glasser
reviewed
Aug 27, 2019
| }); | ||
| }, | ||
| { | ||
| retries: this.options.maxAttempts || 5, |
Member
There was a problem hiding this comment.
I assume this change which passes a "max attempts" (inclusive of first attempt) number to a "retries" (exclusive of first attempt) parameter was unintentional. See #3218.
glasser
added a commit
that referenced
this pull request
Aug 27, 2019
- The behavior of maxAttempts previously failed to match its documentation or the literal reading of its name. Previously, setting maxAttempts=1 would actually result in one retry after the initial attempt. This change fixes the behavior to match the docs and the name. - We intend the bodies of Engine report endpoint errors to be useful in error logs, even 5xx errors. This change returns to including them in the reported error. PR #1274 (merged before the initial release of apollo-engine-reporting) regressed both of these issues.
trevor-scheer
pushed a commit
that referenced
this pull request
Aug 27, 2019
- The behavior of maxAttempts previously failed to match its documentation or the literal reading of its name. Previously, setting maxAttempts=1 would actually result in one retry after the initial attempt. This change fixes the behavior to match the docs and the name. - We intend the bodies of Engine report endpoint errors to be useful in error logs, even 5xx errors. This change returns to including them in the reported error. PR #1274 (merged before the initial release of apollo-engine-reporting) regressed both of these issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for running on non-Node environments like Cloudflare Workers and fly.io, this removes the dependency on the Node request module and replaces its use with fetch.
There is work remaining to remove other dependencies, like gzip and the os module, but this is a first step.