Removes flattening of Errors inside of formatApolloErrors#1288
Merged
Conversation
ghost
mentioned this pull request
abernix
added a commit
that referenced
this pull request
Jul 23, 2019
It shouldn't be necessary to bring this entire `yup` dependency just to test compatibility with the shape of a `yup` (https://npm.im/yup) error. Ref: #1288
abernix
added a commit
that referenced
this pull request
Jul 23, 2019
It shouldn't be necessary to bring this entire `yup` dependency just to test compatibility with the shape of a `yup` (https://npm.im/yup) error. Ref: #1288
abernix
added a commit
that referenced
this pull request
Jul 23, 2019
It shouldn't be necessary to bring this entire `yup` dependency just to test compatibility with the shape of a `yup` (https://npm.im/yup) error. Ref: #1288
abernix
added a commit
that referenced
this pull request
Jul 23, 2019
It shouldn't be necessary to bring this entire `yup` dependency just to test compatibility with the shape of a `yup` (https://npm.im/yup) error. Ref: #1288
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support errors thrown during GraphQL resolution that include nested errors, we need to keep the structure of the errors, rather than flattening them. The reason why the flattening code was present for
mergeSchemasfromgraphql-tools, which returns a combinedError when ever an error is thrown from a remoteSchema.