Skip to content

express, koa: don't continue past playground render#1436

Merged
evans merged 5 commits into
apollographql:masterfrom
wmertens:patch-1
Jul 28, 2018
Merged

express, koa: don't continue past playground render#1436
evans merged 5 commits into
apollographql:masterfrom
wmertens:patch-1

Conversation

@wmertens

Copy link
Copy Markdown
Contributor

Fixes #1420

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@evans evans changed the title server-express: don't continue past playground express, koa: don't continue past playground render Jul 27, 2018
@evans evans merged commit 11abffb into apollographql:master Jul 28, 2018
@evans

evans commented Jul 28, 2018

Copy link
Copy Markdown
Contributor

@wmertens Thank you so much! Turns out we had the issue in koa too, so I went ahead and made that fix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants