Skip to content

fixed: enabled never be false#1578

Merged
abernix merged 8 commits into
apollographql:masterfrom
limerickgds:patch-1
Nov 16, 2018
Merged

fixed: enabled never be false#1578
abernix merged 8 commits into
apollographql:masterfrom
limerickgds:patch-1

Conversation

@limerickgds

@limerickgds limerickgds commented Aug 26, 2018

Copy link
Copy Markdown
Contributor

when playground is undefined , createPlaygroundOptions still set its default value

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

when playground is undefined , createPlaygroundOptions still set its default value
@apollo-cla

Copy link
Copy Markdown

@limerickgds: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@limerickgds limerickgds changed the title fixed: enabled not to be false fixed: enabled never be false Aug 26, 2018
@martijnwalraven

Copy link
Copy Markdown
Contributor

@limerickgds Can you elaborate on what behavior this is expected to enable?

@limerickgds

Copy link
Copy Markdown
Contributor Author

@martijnwalraven i wan't to provide terminal/console use apoolo-server-koa in a production environment. In this code, PlaygroundConfig has default value, enabled is true. so apolloServer. playgroundOptions is always not undefined.

https://github.com/apollographql/apollo-server/blob/master/packages/apollo-server-koa/src/ApolloServer.ts#L138

@abernix

abernix commented Sep 20, 2018

Copy link
Copy Markdown
Member

@limerickgds Are you able to investigate the test failures here?

@limerickgds

Copy link
Copy Markdown
Contributor Author

@abernix done

@abernix abernix merged commit 94f10eb into apollographql:master Nov 16, 2018
@abernix

abernix commented Nov 16, 2018

Copy link
Copy Markdown
Member

I'm pretty sure the actual problem has been fixed in a number of other ways (see any number of Playground-related bug fixes: #1855, #1607, #1586, #1516, #1495), but this still makes the code more clear, and you certainly deserve commit credit for trying. Thanks!

@abernix abernix added this to the Release 2.2.3 milestone Nov 16, 2018
rkorrelboom pushed a commit to rkorrelboom/apollo-server that referenced this pull request Nov 17, 2018
Due to a number of other assignments within `createPlaygroundOptions`, the default is still maintained and the `playground` configuration parameter should be entirely optional.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants