fixed: enabled never be false#1578
Merged
Merged
Conversation
when playground is undefined , createPlaygroundOptions still set its default value
|
@limerickgds: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Contributor
|
@limerickgds Can you elaborate on what behavior this is expected to enable? |
Contributor
Author
|
@martijnwalraven i wan't to provide terminal/console use apoolo-server-koa in a production environment. In this code, PlaygroundConfig has default value, |
Member
|
@limerickgds Are you able to investigate the test failures here? |
Contributor
Author
|
@abernix done |
Member
rkorrelboom
pushed a commit
to rkorrelboom/apollo-server
that referenced
this pull request
Nov 17, 2018
Due to a number of other assignments within `createPlaygroundOptions`, the default is still maintained and the `playground` configuration parameter should be entirely optional.
This was referenced Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when playground is undefined , createPlaygroundOptions still set its default value
TODO: