Skip to content

Fix appolo-server-micro top level error response#1619

Merged
martijnwalraven merged 2 commits into
apollographql:masterfrom
fromthemills:fix-apollo-server-micro-error-response
Sep 5, 2018
Merged

Fix appolo-server-micro top level error response#1619
martijnwalraven merged 2 commits into
apollographql:masterfrom
fromthemills:fix-apollo-server-micro-error-response

Conversation

@fromthemills

@fromthemills fromthemills commented Sep 5, 2018

Copy link
Copy Markdown
Contributor

Fix for (#1581)

apollo-server-micro does not handle context or schema errors correctly. Instead of just throwing when error is caught the error message should be return as the response body.

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@apollo-cla

Copy link
Copy Markdown

@DriesVandermeulen: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@fromthemills fromthemills force-pushed the fix-apollo-server-micro-error-response branch from 0f1401b to c848dd4 Compare September 5, 2018 13:53
@martijnwalraven martijnwalraven merged commit 4ab7bb3 into apollographql:master Sep 5, 2018
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants