Fix header misreporting to engine#1689
Merged
Merged
Conversation
evans
reviewed
Sep 18, 2018
evans
left a comment
Contributor
There was a problem hiding this comment.
@JakeDawkins Thank you for the PR! Not sure why we're getting package-lock differences. Are you running npm 6?
Also can you add this PR to the changelog?
Contributor
Author
|
@evans done! I wasn't on npm 6 🙈 There are still a couple diffs, all changing |
Contributor
|
@JakeDawkins Thank you 🌮 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When using the
privateHeadersoption in the constructor, not all expected headers were being reported to Engine.This was caused because the loop iterating over the headers had a
breakwhere it should have had acontinue, causing the loop to be cut short.Note: This bug didn't cause any private headers to get reported, so no worries there 😄
TODO: