feature(apollo-engine-reporting): Add custom http agent support#1879
Merged
abernix merged 3 commits intoOct 26, 2018
Merged
Conversation
cdcd69d to
bd6f961
Compare
4 tasks
Contributor
Author
Contributor
Author
engine: {
apiKey: 'foo',
requestAgent: proxyUrl ? new HttpsProxyAgent(proxyUrl) : undefined
},and it works like a charm! |
bd6f961 to
831ad90
Compare
abernix
requested changes
Oct 26, 2018
831ad90 to
a94672a
Compare
a94672a to
f66f797
Compare
Contributor
Author
|
@abernix updated! forgot that |
Contributor
Author
|
So the codecov check did not pass, however it is complaining about a file that I did not even touch. |
abernix
approved these changes
Oct 26, 2018
Member
|
This should be published as |
|
@eberhara Where is your example code: located? In the apollo.config.js? Or can it go in my server.js? Because I'd like to use process.env. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1836.
This PR enables developers to inject the http agent to be used on the network requests to apollo engine endpoint.
TODO: