Fix: Serialize arrays as JSON on fetch in RESTDataSource#2219
Merged
Conversation
|
@aireyc1: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
aireyc1
force-pushed
the
fix-fetch-json-array
branch
from
0cf836f to
c37f781
Compare
abernix
reviewed
Feb 4, 2019
| options.body !== undefined && | ||
| options.body !== null && | ||
| (options.body.constructor === Object || | ||
| options.body.constructor === Array || |
Member
There was a problem hiding this comment.
It's obviously not common to sub-class an Array, but could/should we switch this to use Array.isArray instead to help accommodate that?
aireyc1
force-pushed
the
fix-fetch-json-array
branch
from
c37f781 to
74c7627
Compare
aireyc1
force-pushed
the
fix-fetch-json-array
branch
from
74c7627 to
e8e4902
Compare
Lerna will take care of this on publishing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue introduced in #1125 and logged in #2186 and #2196.
Arrays are valid JSON per spec: https://tools.ietf.org/html/rfc7159
TODO: