More strict check for node version for graphql-upload#2235
Merged
Conversation
|
@mrkurt: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Since this predicate is no longer Node-specific, this changes the name of (an internal API) to reflect its new nature. Follows-up: apollographql#2235 cc @mrkurt
Member
|
Thank you for this! I made a couple follow-up commits to correct the name of the method and its file (which were no longer intuitive after this change), but this was released in v2.3.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a
apollo-server-flyiopackage to use in fly.io apps. The fly app environment is not node, it's much closer to the browser, which means no access tofs, which meansgraphql-uploadblows up on require.This PR makes the Node version check more strict — if there are no node process details it avoids requiring the
graphql-uploadpackage for non-node runtimes. This is useful for me, obviously, but should also improve the Cloud Flare worker build experience and help with any future Deno efforts.TODO: