Migrate apollo-graphql package to apollo-tooling repo#2316
Merged
Conversation
4 tasks
abernix
approved these changes
Feb 14, 2019
abernix
left a comment
abernix
left a comment
Member
There was a problem hiding this comment.
Looks great to me. I thought about not merging this until after apollographql/apollo-tooling#1018 landed but I believe it's actually safer to not keep this code around in apollo-server and risk two copies getting changed independently. Consider this a temporary apollo-graphql code-freeze! 😉
If this ends up sending someone looking for the apollo-graphql source I hope this PR helps them, but I'm otherwise sorry for the temporary inconvenience. The new home for apollo-graphql is in apollo-tooling.
Thanks for doing this, @trevor-scheer !
| // We don't want to match `apollo-server-env` and | ||
| // `apollo-engine-reporting-protobuf`, because these don't depend on | ||
| // compilation but need to be initialized from as parto of `prepare`. | ||
| '^(?!apollo-server-env|apollo-engine-reporting-protobuf)(apollo-(?:server|graphql|datasource|cache-control|tracing|engine)[^/]*|graphql-extensions)(?:/dist)?((?:/.*)|$)': '<rootDir>/../../packages/$1/src$2' |
Member
There was a problem hiding this comment.
Great job catching this subtlety!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to remove the
apollo-graphqlpackage from this repository, to be added toapollo-toolinginstead.TODO: