Skip to content

export ExpressContext#2352

Merged
cheapsteak merged 2 commits into
apollographql:masterfrom
KATT:express-context
Feb 21, 2019
Merged

export ExpressContext#2352
cheapsteak merged 2 commits into
apollographql:masterfrom
KATT:express-context

Conversation

@KATT

@KATT KATT commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

Original: #2349

Kept some tiny stuff that has very little value now, but anyway 🤷‍♂️


TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@KATT KATT force-pushed the express-context branch 4 times, most recently from fa954b9 to defd741 Compare February 21, 2019 18:31
@KATT KATT marked this pull request as ready for review February 21, 2019 18:32

@cheapsteak cheapsteak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!
Thanks so much for this, and also appreciate your work on #2349 as well (and apologies for the mixup that caused that bug, hope it didn't cause you to lose too much time)

update: released as 2.4.5

@cheapsteak cheapsteak merged commit 2a9ad9f into apollographql:master Feb 21, 2019
@cheapsteak cheapsteak changed the title Express context export Express context Feb 21, 2019
@cheapsteak cheapsteak changed the title export Express context export ExpressContext Feb 21, 2019
@KATT KATT deleted the express-context branch February 22, 2019 13:42
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants