Fix Headers bug in IE11#2607
Merged
Merged
Conversation
67cf03c to
c8714cf
Compare
Contributor
Author
|
I haven't added tests for this, as I am unsure if you've got any IE11 targets in your test suites. Edit: In IE11, it's running using the default polyfills. |
c8714cf to
78825c6
Compare
When calling `new Headers(undefined)` in IE11 an `Invalid argument` exception is thrown. With this in place, we'll call it with an empty object, resulting in an empty Headers object.
78825c6 to
df5d8f4
Compare
abernix
approved these changes
Apr 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
new Headers(undefined)in IE11 anInvalid argumentexception is thrown.With this in place, we'll call it with an empty object, resulting in an empty Headers object.
TODO:
Edit:
I mistakenly wrote
null, where I meant to writeundefined.