Add forbidden and registered operations to requestContext.metrics - AP-478#2768
Merged
Conversation
cheapsteak
changed the title
cheapsteak
changed the title
cheapsteak
force-pushed
the
chang/operation-registry/reporting
branch
from
14317e8 to
0f6db12
Compare
evans
approved these changes
Jun 4, 2019
evans
left a comment
evans
left a comment
Contributor
There was a problem hiding this comment.
Awesome stuff! Appreciate you for setting these changes up
cheapsteak
force-pushed
the
chang/operation-registry/reporting
branch
from
0f6db12 to
48ecbed
Compare
cheapsteak
force-pushed
the
chang/operation-registry/reporting
branch
from
48ecbed to
1a296b7
Compare
trevor-scheer
pushed a commit
that referenced
this pull request
May 6, 2020
Those fields were added by #2768
trevor-scheer
pushed a commit
that referenced
this pull request
May 12, 2020
Those fields were added by #2768
trevor-scheer
pushed a commit
that referenced
this pull request
May 14, 2020
Those fields were added by #2768
trevor-scheer
pushed a commit
that referenced
this pull request
May 14, 2020
Those fields were added by #2768
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
reports.proto, addsforbiddenOperationandregisteredOperationboolean fields toGraphQLRequestMetrics, and sets those fields on the outgoing traceThe intention is for the operation registry plugin to set these values on requestContext.metrics